Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): Only use Arc<NetworkProver> in real proof mode #387

Merged
merged 3 commits into from
Feb 13, 2025
Merged

feat(server): Only use Arc<NetworkProver> in real proof mode #387

merged 3 commits into from
Feb 13, 2025

Conversation

fakedev9999
Copy link
Member

@fakedev9999 fakedev9999 commented Feb 13, 2025 •
edited by ratankaliani
Loading

Prevents getting below error in case where OP_SUCCINCT_MOCK=true but NETWORK_PRIVATE_KEY not set.

op-succinct-server-1    | NETWORK_PRIVATE_KEY environment variable is not set. Please set it to your private key or use the .private_key() method.

In Mock mode, we don't generate proofs through the prover network, so we should just use the MockProver for now. This will incur additional memory usage, and we'll optimize it in a future PR.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 13, 2025 •
edited
Loading

Metric Value
Batch Start 23,833,530
Batch End 23,833,535
Witness Generation (seconds) 0
Execution Duration (seconds) 38
Total Instruction Count 1,551,976,441
Oracle Verify Cycles 278,535,473
Derivation Cycles 898,932,687
Block Execution Cycles 284,467,472
Blob Verification Cycles 128,024,122
Total SP1 Gas 0
Number of Blocks 5
Number of Transactions 39
Ethereum Gas Used 15,647,603
Cycles per Block 310,395,288
Cycles per Transaction 39,794,267
Transactions per Block 7
Gas Used per Block 3,129,520
Gas Used per Transaction 401,220
BN Pair Cycles 0
BN Add Cycles 0
BN Mul Cycles 0
KZG Eval Cycles 0
EC Recover Cycles 106,560
P256 Verify Cycles 0

@ratankaliani ratankaliani changed the title feat(proposer): set default network private key feat(proposer): Only use Arc<NetworkProver in real proof mode Feb 13, 2025
@ratankaliani ratankaliani changed the title feat(proposer): Only use Arc<NetworkProver in real proof mode feat(proposer): Only use Arc<NetworkProver> in real proof mode Feb 13, 2025
@ratankaliani ratankaliani changed the title feat(proposer): Only use Arc<NetworkProver> in real proof mode feat(server): Only use Arc<NetworkProver> in real proof mode Feb 13, 2025
@ratankaliani ratankaliani force-pushed the taehoon/set-default-pk branch from 1282cc9 to 9202b2b Compare February 13, 2025 18:39
@ratankaliani ratankaliani merged commit 7f8e60f into main Feb 13, 2025
6 checks passed
@ratankaliani ratankaliani deleted the taehoon/set-default-pk branch February 13, 2025 18:39
PinelliaC added a commit to mantle-xyz/op-succinct that referenced this pull request Feb 18, 2025
@PinelliaC @fakedev9999
@puma314 @ratankaliani
feat: bump op-succinct version into v1.2.2 (#6)
068368e 
* feat: implement OPSuccinctFaultDisputeGame (succinctlabs#342)

* feat: implement OPSuccinctFaultDisputeGame

* apply comments

* apply comments

* chore: forge fmt

* chore: forge fmt src/ test/ script/

* fix .gitmodules

* fix .gitmodules

* fix .gitmodules

* fix: add missing checks

* chore: forge fmt

* fix .gitmodules

* fix submodules

* feat: implement with new spec

* fix: handle first game

* apply comments

* fix: range vkey, public values from contract storage

* missing fix from ^

* refac: use deadline, proposal status instead of clock

* feat: use genesis l2 block number and hash for initial game

* apply all comments

* feat: make unchallenged games provable

* apply comments

* chore: remove warnings

* test: add more tests

* refac: use payable transfer instead of call

* refac: remove claimant from claimData

claimant never changes + can get from gameCreator()

* fix: remove l2 chain id

* apply comments

* first

* udpate doc

* docs: make fault proof doc visible in the book

* enable mermaid in book

---------

Co-authored-by: Uma Roy <[email protected]>

* docs: update `fault_proof_architecture.md` (succinctlabs#353)

* docs: fix mermaid diagram

* docs: update immutable params

* docs: make doc more comprehensive

* docs: minor updates

* docs: make initalization more clear in terms of initial state

* docs: add types section for new/modified types

* fix: update OPSuccinctFaultDisputeGame with nits (succinctlabs#354)

* fix: update OPSuccinctFaultDisputeGame with nits

* docs: fix proving section

* feat: upgrade to latest `kona` (succinctlabs#344)

* feat: wip, running into fd issues bc zkvm mode

* wip

* add

* wip

* feat: program compiles

* feat: still working through host issues, many of the scripts aren't compiling, making progress

* wip

* update

* wip

* feat: need to clean up host lib

* feat: drop the kv_store so there are no conflicting locks

* add

* feat: move to latest kona

* add

* fix: DOckerfile

* add

* clippy

* fix

* redundant

* fix

* feat: todo

* multi works

* feat: small program works

* feat: got store_oracle working

* remove configs

* feat: works with new blob provider

* feat: docs

* feat: works with upstream kona

* add cycle tracking

* add

* feat: add driver with logging

* fix: more efficient than before

* feat: delete single

* add

* feat: general cleanup

* fix

* clippy

* fix

* clean

* add

* clean

* rm bootinfowithbytesconfig

* feat: new elf

* add

* refactor

* add

* remove configs

* delete

* remove test

* update

* fmt

* feat: in parallel

* feat: update elf

* feat: simplify

* host

* feat: show entire diff

* clippy

* feat: trigger workflow

* feat: fix cost estimator

* add

* chore: remove slack token (succinctlabs#364)

* feat: remove slack token

* tidy

* feat: update

* add

* feat(fetcher): Use finalized block (succinctlabs#366)

* feat(proposer): don't re-checkpoint (succinctlabs#365)

* feat: dont recheckpoint in proposer

* add

* chore: `sp1-sdk` (succinctlabs#368)

* docs: issue template

* chore: `kona` + `sp1` upgrade (succinctlabs#376)

* feat: kona upgrade

* cargo fmt

* delete safe_head_hash

* fmt

* rm

* clippy

* test fix

* add

* works

* expose start_server

* add

* add

* fix: Rust install

* add

* move witnessgen

* add

* lint

* bump to 4.1.0

* one week rolling

* add

* feat: add

* clean

* add

* ad

* add

* ELF

* chore: Use `op-rs` upstream (succinctlabs#379)

* feat(server): add proof mode (succinctlabs#380)

* feat: add agg proof mode

* add

* chore: remove bls patch (succinctlabs#381)

* feat: add agg proof mode

* add

* chore: remove bls patch

* feat(server): debug logs (succinctlabs#351)

* feat: boba debug branch

* fix

* enable push

* fix

* additional debug logs

* build succinct-proposer first

* feat: fetch in order

* add

* add

* rm logs

* fix

* chore: fmt

* chore: trigger docker build (succinctlabs#382)

* feat: `kona` pectra tag (succinctlabs#384)

* chore: kona pectra tag

* docker elf

* chore(server): `Arc` shared state (succinctlabs#385)

* chore: wrap proposer config in arc

* chore: fmt

* fmt

* feat(contracts): use `DisputeGameFactory` (succinctlabs#378)

* feat(contracts): use `DisputeGameFactory`

Removes unnecessary `OPSuccinctDisputeGameFactory`

* fix: fix proposer to call DFG correctly

* fix: make op-succinct validity working with op's dgf

* cleanup

* update

* apply comments

* feat(contracts): remove bond for validity DGF (succinctlabs#386)

* feat(server): Only use `Arc<NetworkProver>` in real proof mode (succinctlabs#387)

* feat(proposer): set default network private key

* add

* fmt

---------

Co-authored-by: Ratan Kaliani <[email protected]>

* chore: Switch to `OPSuccinctHost` (succinctlabs#389)

* chore: clippy

* chore: fix just update-parameters (succinctlabs#392)

* chore: fix contract verification (succinctlabs#391)

* chore(ci): docker tag (succinctlabs#393)

* chore(client + ci): precompile annotation checks (succinctlabs#390)

* chore: kzg_eval precompile

* feat: bump to revm_precompile 0.16.1

* wip

* chore: precompile

* works

* add

* addgs

* ci.yaml

* remove unnecessary tests

* ci

* add

* range elf

* add

* chore(ci): docker build

* fix(proposer): bindings (succinctlabs#396)

* chore: add go test

* checkout

* add

* fix test

* feat: update range elf

* chore: remove unused code

* elf: update range elf

---------

Co-authored-by: fakedev9999 <[email protected]>
Co-authored-by: Uma Roy <[email protected]>
Co-authored-by: Ratan Kaliani <[email protected]>
Co-authored-by: ratankaliani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ratankaliani ratankaliani Awaiting requested review from ratankaliani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fakedev9999 @ratankaliani