-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contracts): update OPSuccinctFaultDisputeGame
#394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ff2def
to
b06fc4b
Compare
|
puma314
reviewed
Feb 15, 2025
05c9d1b
to
bd80140
Compare
Fixes below error ``` Error: failed to resolve file: "/home/runner/work/op-succinct/op -succinct/contracts/lib/lib-keccak/contracts/lib/LibKeccak.sol": No such file or directory (os error 2); check configured remappings --> /home/runner/work/op-succinct/op-succinct/contracts/lib/ optimism/packages/contracts-bedrock/interfaces/cannon/ IPreimageOracle.sol @lib-keccak/LibKeccak.sol ```
bd80140
to
a8e2418
Compare
00e2372
to
2f630ea
Compare
puma314
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new features to
OPSuccinctFaultDisputeGame
Air gap for finalization + anchor state update
We now have game life cycle of proposed -> resolved -> finalized, where finalized is done by calling
claimCredit
after the air gap.Allowing game creation with a parent with different game type
Previously we had a parent game type check on creation, but now it's removed for efficiency of recovery in case of game retirement.
We now allow game creation with a retired but not blacklisted, respected parent game
Bond refund mechanism for improper games
For improper games (either not registered, blacklisted or game type retired), bonds are now refunded.
Permissioned games with
AccessManager.sol
Permissioned games for whitelisted proposers and challengers are supported. Access management can be done through
AccessManager
contract, which is set as an immutable variable in the game implementation.