feat: elliptic-curves p256/k256 integration, universal Fp ops hooks
#2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratankaliani
reviewed
Feb 4, 2025
ratankaliani
reviewed
Feb 4, 2025
ratankaliani
reviewed
Feb 4, 2025
ratankaliani
reviewed
Feb 4, 2025
rkm0959
reviewed
Feb 4, 2025
rkm0959
reviewed
Feb 4, 2025
rkm0959
reviewed
Feb 4, 2025
rkm0959
reviewed
Feb 5, 2025
rkm0959
reviewed
Feb 5, 2025
|
Can you update the documentation with the new patches as well? Or create another PR which shows the updated patch tags? |
ratankaliani
reviewed
Feb 5, 2025
ratankaliani
reviewed
Feb 5, 2025
ratankaliani
reviewed
Feb 5, 2025
ratankaliani
reviewed
Feb 5, 2025
ratankaliani
reviewed
Feb 5, 2025
ratankaliani
reviewed
Feb 5, 2025
ratankaliani
reviewed
Feb 5, 2025
ratankaliani
reviewed
Feb 5, 2025
ratankaliani
reviewed
Feb 5, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
| //! Weierstrass precompiles. | ||
| //! | ||
| //! In summary, SP1 overrides curve arithmetic entirely, and patches upstream field operations | ||
| //! to be more effcient in the VM, such as `sqrt` or `inverse`. |
There was a problem hiding this comment.
typos:
Suggested change
| //! to be more effcient in the VM, such as `sqrt` or `inverse`. | |
| //! to be more efficient in the VM, such as `sqrt` or `inverse`. |
| type FIELD_BYTES_SIZE = U32; | ||
|
|
||
| /// A [`CurveArithmetic`] implementation for SP1 acceleration. | ||
| /// Patched crates will implement this trait to expose thier field element type to us. |
There was a problem hiding this comment.
typos:
Suggested change
| /// Patched crates will implement this trait to expose thier field element type to us. | |
| /// Patched crates will implement this trait to expose their field element type to us. |
| /// | ||
| /// This "newtype" is needed due to some limitations of GATs. | ||
| /// | ||
| /// Specfically, its impossible to generically implement |
There was a problem hiding this comment.
typos:
Suggested change
| /// Specfically, its impossible to generically implement | |
| /// Specifically, its impossible to generically implement | |
| ++ b/crates/zkvm/lib/src/ecdsa/projective.rs |
| // type `Scalar = <C as CurveArithmetic>::Scalar`, | ||
| // | ||
| // For more information: | ||
| // see the rationale in the documention of `<C as ECDSACruve>::ScalarImpl`. |
There was a problem hiding this comment.
typos:
Suggested change
| // see the rationale in the documention of `<C as ECDSACruve>::ScalarImpl`. | |
| // see the rationale in the documentation of `<C as ECDSACruve>::ScalarImpl`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.