optimize: remove lock of globalMasterInfo (apache#2151)

suesunss · Mar 14, 2023 · 6409d92 · 6409d92
1 parent 82c7e78
commit 6409d92
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 24 deletions.
diff --git a/hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/RedirectFilter.java b/hugegraph-api/src/main/java/org/apache/hugegraph/api/filter/RedirectFilter.java
@@ -76,23 +76,22 @@ public void filter(ContainerRequestContext context) throws IOException {
         E.checkState(handle != null, "Context GraphManager is absent");
         GraphManager manager = handle.getService();
         E.checkState(manager != null, "Context GraphManager is absent");
-        GlobalMasterInfo globalMasterInfo = manager.globalMasterInfo();
-        if (globalMasterInfo == null || !globalMasterInfo.isFeatureSupport()) {
-            return;
-        }
 
         String redirectTag = context.getHeaderString(X_HG_REDIRECT);
         if (StringUtils.isNotEmpty(redirectTag)) {
             return;
         }
 
-        String url;
-        synchronized (globalMasterInfo) {
-            if (globalMasterInfo.isMaster() || StringUtils.isEmpty(globalMasterInfo.url())) {
-                return;
-            }
-            url = globalMasterInfo.url();
+        GlobalMasterInfo globalMasterInfo = manager.globalMasterInfo();
+        if (globalMasterInfo == null || !globalMasterInfo.isFeatureSupport()) {
+            return;
+        }
+        GlobalMasterInfo.NodeInfo masterNodeInfo = globalMasterInfo.nodeInfo();
+        if (masterNodeInfo == null || masterNodeInfo.isMaster() ||
+            StringUtils.isEmpty(masterNodeInfo.url())) {
+            return;
         }
+        String url = masterNodeInfo.url();
 
         URI redirectUri;
         try {

diff --git a/hugegraph-core/src/main/java/org/apache/hugegraph/masterelection/GlobalMasterInfo.java b/hugegraph-core/src/main/java/org/apache/hugegraph/masterelection/GlobalMasterInfo.java
@@ -19,26 +19,22 @@
 
 public class GlobalMasterInfo {
 
-    private boolean isMaster;
-    private String url;
-
+    private NodeInfo nodeInfo;
     private volatile boolean featureSupport;
 
     public GlobalMasterInfo() {
         this.featureSupport = false;
+        this.nodeInfo = new NodeInfo(false, "");
     }
 
-    public synchronized void set(boolean isMaster, String url) {
-        this.isMaster = isMaster;
-        this.url = url;
-    }
-
-    public synchronized boolean isMaster() {
-        return this.isMaster;
+    public final void nodeInfo(boolean isMaster, String url) {
+        // final can avoid instruction rearrangement, visibility can be ignored
+        final NodeInfo tmp = new NodeInfo(isMaster, url);
+        this.nodeInfo = tmp;
     }
 
-    public synchronized String url() {
-        return this.url;
+    public final NodeInfo nodeInfo() {
+        return this.nodeInfo;
     }
 
     public void isFeatureSupport(boolean featureSupport) {
@@ -48,4 +44,23 @@ public void isFeatureSupport(boolean featureSupport) {
     public boolean isFeatureSupport() {
         return this.featureSupport;
     }
+
+    public static class NodeInfo {
+
+        private final boolean isMaster;
+        private final String url;
+
+        public NodeInfo(boolean isMaster, String url) {
+            this.isMaster = isMaster;
+            this.url = url;
+        }
+
+        public boolean isMaster() {
+            return this.isMaster;
+        }
+
+        public String url() {
+            return this.url;
+        }
+    }
 }
diff --git a/...-core/src/main/java/org/apache/hugegraph/masterelection/StandardStateMachineCallback.java b/...-core/src/main/java/org/apache/hugegraph/masterelection/StandardStateMachineCallback.java
@@ -94,12 +94,12 @@ public void error(StateMachineContext context, Throwable e) {
     public void initGlobalMasterInfo(StateMachineContext context) {
         StateMachineContext.MasterServerInfo master = context.master();
         if (master == null) {
-            this.globalMasterInfo.set(false, null);
+            this.globalMasterInfo.nodeInfo(false, "");
             return;
         }
 
         boolean isMaster = Objects.equals(context.node(), master.node());
         String url = master.url();
-        this.globalMasterInfo.set(isMaster, url);
+        this.globalMasterInfo.nodeInfo(isMaster, url);
     }
 }