Clean-up examples

suifeng0001 · Dec 15, 2017 · c7bb4a7 · c7bb4a7
1 parent 2e4679e
commit c7bb4a7
Show file tree

Hide file tree

Showing 13 changed files with 18 additions and 78 deletions.
diff --git a/examples/Boost-chrono/CMakeLists.txt b/examples/Boost-chrono/CMakeLists.txt
@@ -9,10 +9,8 @@ include("../common.cmake")
 
 project(download-boost)
 
-# download boost
 hunter_add_package(Boost COMPONENTS system chrono)
-
-# now boost can be used
 find_package(Boost CONFIG REQUIRED system chrono)
+
 add_executable(foo foo.cpp)
-target_link_libraries(foo Boost::system Boost::chrono)
+target_link_libraries(foo PUBLIC Boost::system Boost::chrono)
diff --git a/examples/Boost-compute/CMakeLists.txt b/examples/Boost-compute/CMakeLists.txt
@@ -9,11 +9,8 @@ include("../common.cmake")
 
 project(download-boost-compute)
 
-# download boost.compute
 hunter_add_package(BoostCompute)
-
-# now boost.compute can be used
 find_package(BoostCompute CONFIG REQUIRED)
 
 add_executable(foo foo.cpp)
-target_link_libraries(foo BoostCompute::boost_compute)
+target_link_libraries(foo PUBLIC BoostCompute::boost_compute)
diff --git a/examples/Boost-filesystem-shared/CMakeLists.txt b/examples/Boost-filesystem-shared/CMakeLists.txt
@@ -10,12 +10,8 @@ include("../common.cmake")
 
 project(download-boost)
 
-# download boost
 hunter_add_package(Boost COMPONENTS system filesystem)
-
-# now boost can be used
 find_package(Boost CONFIG REQUIRED system filesystem)
 
 add_executable(foo foo.cpp)
-
-target_link_libraries(foo Boost::system Boost::filesystem)
+target_link_libraries(foo PUBLIC Boost::system Boost::filesystem)
diff --git a/examples/Boost-filesystem/CMakeLists.txt b/examples/Boost-filesystem/CMakeLists.txt
@@ -32,15 +32,6 @@ endif()
 
 target_link_libraries(foo Boost::system Boost::filesystem)
 
-# Compatibility mode
-set(Boost_USE_STATIC_LIBS ON)
-if(MSVC)
-  add_definitions(-DBOOST_ALL_NO_LIB=1)
-endif()
-find_package(Boost REQUIRED system filesystem)
-include_directories("${Boost_INCLUDE_DIRS}")
-target_link_libraries(foo ${Boost_LIBRARIES})
-
 if(ANDROID)
   target_link_libraries(foo log android)
   target_include_directories(

diff --git a/examples/Boost-iostreams/CMakeLists.txt b/examples/Boost-iostreams/CMakeLists.txt
@@ -9,19 +9,8 @@ include("../common.cmake")
 
 project(boost_iostreams)
 
-# download boost
 hunter_add_package(Boost COMPONENTS iostreams serialization)
-
-# now boost can be used
 find_package(Boost CONFIG REQUIRED iostreams serialization)
-add_executable(foo foo.cpp)
-target_link_libraries(foo Boost::iostreams Boost::serialization)
 
-# Compatibility mode
-set(Boost_USE_STATIC_LIBS ON)
-if(MSVC)
-  add_definitions(-DBOOST_ALL_NO_LIB=1)
-endif()
-find_package(Boost REQUIRED iostreams)
-include_directories(${Boost_INCLUDE_DIRS})
-target_link_libraries(foo ${Boost_LIBRARIES})
+add_executable(foo foo.cpp)
+target_link_libraries(foo PUBLIC Boost::iostreams Boost::serialization)
diff --git a/examples/Boost-log/CMakeLists.txt b/examples/Boost-log/CMakeLists.txt
@@ -9,10 +9,8 @@ include("../common.cmake")
 
 project(download-boost)
 
-# download boost
 hunter_add_package(Boost COMPONENTS log)
-
-# now boost can be used
 find_package(Boost CONFIG REQUIRED log)
+
 add_executable(foo foo.cpp)
-target_link_libraries(foo Boost::log)
+target_link_libraries(foo PUBLIC Boost::log)
diff --git a/examples/Boost-process/CMakeLists.txt b/examples/Boost-process/CMakeLists.txt
@@ -9,11 +9,8 @@ include("../common.cmake")
 
 project(example-boost-process)
 
-# download boost.process
 hunter_add_package(BoostProcess)
-
-# now boost.process can be used
 find_package(BoostProcess CONFIG REQUIRED)
 
 add_executable(foo foo.cpp)
-target_link_libraries(foo BoostProcess::boost_process)
+target_link_libraries(foo PUBLIC BoostProcess::boost_process)
diff --git a/examples/Boost-random/CMakeLists.txt b/examples/Boost-random/CMakeLists.txt
@@ -9,10 +9,8 @@ include("../common.cmake")
 
 project(download-boost-random)
 
-# download boost-random
 hunter_add_package(Boost COMPONENTS random)
-
-# now boost can be used
 find_package(Boost CONFIG REQUIRED random)
+
 add_executable(foo foo.cpp)
-target_link_libraries(foo Boost::random)
+target_link_libraries(foo PUBLIC Boost::random)
diff --git a/examples/Boost-serialization/CMakeLists.txt b/examples/Boost-serialization/CMakeLists.txt
@@ -13,4 +13,4 @@ hunter_add_package(Boost COMPONENTS serialization)
 find_package(Boost CONFIG REQUIRED serialization)
 
 add_executable(foo foo.cpp)
-target_link_libraries(foo Boost::serialization)
+target_link_libraries(foo PUBLIC Boost::serialization)
diff --git a/examples/Boost-system/CMakeLists.txt b/examples/Boost-system/CMakeLists.txt
@@ -9,19 +9,8 @@ include("../common.cmake")
 
 project(download-boost)
 
-# download boost
 hunter_add_package(Boost COMPONENTS system)
-
-# now boost can be used
 find_package(Boost CONFIG REQUIRED system)
-add_executable(foo foo.cpp)
-target_link_libraries(foo Boost::system)
 
-# Compatibility mode
-set(Boost_USE_STATIC_LIBS ON)
-if(MSVC)
-  add_definitions(-DBOOST_ALL_NO_LIB=1)
-endif()
-find_package(Boost REQUIRED system)
-include_directories(${Boost_INCLUDE_DIRS})
-target_link_libraries(foo ${Boost_LIBRARIES})
+add_executable(foo foo.cpp)
+target_link_libraries(foo PUBLIC Boost::system)
diff --git a/examples/Boost-thread/CMakeLists.txt b/examples/Boost-thread/CMakeLists.txt
@@ -9,11 +9,8 @@ include("../common.cmake")
 
 project(download-boost)
 
-# download boost
 hunter_add_package(Boost COMPONENTS system thread)
-
-# now boost can be used
 find_package(Boost CONFIG REQUIRED system thread)
-add_executable(foo foo.cpp)
-target_link_libraries(foo Boost::system Boost::thread)
 
+add_executable(foo foo.cpp)
+target_link_libraries(foo PUBLIC Boost::system Boost::thread)
diff --git a/examples/Boost-uuid/CMakeLists.txt b/examples/Boost-uuid/CMakeLists.txt
@@ -9,11 +9,8 @@ include("../common.cmake")
 
 project(download-boost)
 
-# download boost
 hunter_add_package(Boost)
-
-# now boost can be used
 find_package(Boost CONFIG REQUIRED)
 
 add_executable(foo foo.cpp)
-target_link_libraries(foo Boost::boost)
+target_link_libraries(foo PUBLIC Boost::boost)
diff --git a/examples/Boost/CMakeLists.txt b/examples/Boost/CMakeLists.txt
@@ -9,14 +9,11 @@ include("../common.cmake")
 
 project(download-boost)
 
-# download boost
 hunter_add_package(Boost)
-
-# now boost can be used
 find_package(Boost CONFIG REQUIRED)
 
 add_executable(foo foo.cpp)
-target_link_libraries(foo Boost::boost)
+target_link_libraries(foo PUBLIC Boost::boost)
 
 set(project_license "${CMAKE_CURRENT_BINARY_DIR}/LICENSE.txt")
 file(
@@ -40,7 +37,3 @@ foreach(x ${Boost_LICENSES})
 endforeach()
 
 message("Project license: ${project_license}")
-
-# Compatibility mode
-find_package(Boost REQUIRED)
-include_directories("${Boost_INCLUDE_DIRS}")