feat: if upgrade 17 -> 17 modify upgrade process #1583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delgado3d
approved these changes
May 5, 2025
samrose
force-pushed
the
sam/pgupgrade-17-17
branch
from
5decf23 to
1dbf0fe
Compare
za-arthur
reviewed
May 7, 2025
samrose
changed the title
|
Still iterating on testing |
samrose
force-pushed
the
sam/pgupgrade-17-17
branch
from
13dccd2 to
b4a58fa
Compare
… the option directly when pg_upgrade is executed (-c)
samrose
force-pushed
the
sam/pgupgrade-17-17
branch
from
b4a58fa to
28cb728
Compare
delgado3d
approved these changes
May 15, 2025
|
Passed all tests merging |
damonrand
pushed a commit
to cepro/postgres
that referenced
this pull request
Jun 15, 2025
* feat: if upgrade 17 -> 17 or 17-orioledb -> 17-orioledb do not run these queries * feat: handle all cases of SERVER_LC_COLLATE and SERVER_LC_CTYPE * fix: explixit set on 17/oriole * feat: handling max_slot_wal_keep_size for pg 17 was needed as well * feat: binary upgrades require max_slot_wal_keep_size to be -1 during binary upgrade * fix: Better to override that during the upgrade process by specifying the option directly when pg_upgrade is executed (-c) * fix: cover only pg 17 * fix: rm oriole handling * fix: do not need max_slot_wal_keep_size on old version * fix: temp config on new-options too * fix: remove unbound var * chore: remove complete.sh change that should not have been committed * chore: bump for testing * chore: stash code * feat: working pg 17 upgrade * feat: pg 15 handling * feat: rm oriole handling, refine 15 -> 17 config * feat: make sure old pg stops if not force stop * chore: bump version * chore: cleanup + bump version for test * fix: rollback to working version with fix from divit * chore: version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If major pg version upgrade is 17 -> or 17-orioledb -> orioledb we don't want to run these queries.