fix: needed a release to rollout fixes that address pgmq issues #1693
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
za-arthur
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1471
To roll out new upgrade scripts for a new Postgres version, you must update the relevant version in ansible/vars.yml. The workflow will use whatever is defined there as the source of truth for Postgres versions and release strings.
you can see in https://github.com/supabase/postgres/blob/develop/.github/workflows/publish-nix-pgupgrade-bin-flake-version.yml and https://github.com/supabase/postgres/blob/develop/.github/workflows/publish-nix-pgupgrade-scripts.yml
The workflow explicitly reads versions from ansible/vars.yml:
In the prepare job, it runs: VERSIONS=$(nix run nixpkgs#yq -- '.postgres_major[]' ansible/vars.yml | nix run nixpkgs#jq -- -R -s -c 'split("\n")[:-1]') This extracts the list of Postgres major versions directly from the .postgres_major array in ansible/vars.yml.
It looks up exact release strings from ansible/vars.yml for each version: In both publish-staging and publish-prod jobs, it runs: VERSION=(nix{{ matrix.postgres_version }}'"]' ansible/vars.yml)
This uses the major version (from the previous step) to look up the corresponding release string in .postgres_release in ansible/vars.yml.
The workflow uses these values for publishing: The workflow matrix cycles through each version found in ansible/vars.yml. All script uploads, tarball creation, and artifact naming are based on these values.
Unless you explicitly override the version via workflow_dispatch input, these values are always sourced from ansible/vars.yml.
.github/workflows/publish-nix-pgupgrade-scripts.yml is also tied to the version and release info in ansible/vars.yml. To roll out upgrade scripts for new Postgres versions, you must update ansible/vars.yml with the new version and release string.