resolve #5939 Theme Editor - Logo alignment property is not working f…

…or a basic header (#5954) Co-authored-by: OlgaLarina <[email protected]>
surveyjs · Oct 11, 2024 · 406a4eb · 406a4eb
1 parent 4b8a95f
commit 406a4eb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/packages/survey-creator-core/src/components/tabs/theme-plugin.ts b/packages/survey-creator-core/src/components/tabs/theme-plugin.ts
@@ -425,6 +425,7 @@ export class ThemeTabPlugin implements ICreatorPlugin {
  }
  if (options.name == "logoPosition") {
  this.creator.survey.logoPosition = options.value;
+ this.model.survey.logoPosition = options.value;
  }
  this.resetTheme.enabled = true;
  this.saveThemeAction.enabled = true;

diff --git a/packages/survey-creator-core/tests/tabs/theme-model-property-grid.tests.ts b/packages/survey-creator-core/tests/tabs/theme-model-property-grid.tests.ts
@@ -782,13 +782,15 @@ test("set headerViewContainer basic", (): any => {
 
  const themePlugin: ThemeTabPlugin = <ThemeTabPlugin>creator.getPlugin("theme");
  themePlugin.activate();
+ const simulatorSurvey = themePlugin.model.survey;
  const themeModel = themePlugin.themeModel as ThemeModel;
  const groupHeader = themePlugin.propertyGrid.survey.pages[0].getElementByName("header");
  const headerViewContainer = groupHeader.elements[0].contentPanel;
  const surveyTitleQuestion = headerViewContainer.getElementByName("surveyTitle");
  const surveyDescriptionQuestion = headerViewContainer.getElementByName("surveyDescription");
  const header = themeModel.header as HeaderModel;
 
+ expect(simulatorSurvey.logoPosition).toEqual("left");
  expect(creator.survey.logoPosition).toEqual("left");
  expect(header["surveyTitle"]).toStrictEqual({ family: "Open Sans", weight: "700", size: 32 });
  expect(header["surveyDescription"]).toStrictEqual({ family: "Open Sans", weight: "400", size: 16 });
@@ -806,6 +808,7 @@ test("set headerViewContainer basic", (): any => {
 
  expect(creator.theme.header).toBeUndefined();
  expect(creator.survey.logoPosition).toEqual("right");
+ expect(simulatorSurvey.logoPosition).toEqual("right");
 });
 
 test("set headerViewContainer basic restore", (): any => {