Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support typed arrays in load functions #12716

Merged
merged 1 commit into from
Sep 27, 2024
Merged

feat: support typed arrays in load functions #12716

merged 1 commit into from
Sep 27, 2024

Conversation

Rich-Harris
Copy link
Member

Adds support for returning typed arrays and array buffers from load functions. Not something to over-use, since it uses base64 encoding which is 33% larger than the raw data, but useful when you need it.

Thanks for @LorisSigrist for implementing this in Rich-Harris/devalue#69. No test because it's a devalue feature


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Sep 25, 2024

🦋 Changeset detected

Latest commit: 68eb397

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 5b40b04 into main Sep 27, 2024
12 of 13 checks passed
@Rich-Harris Rich-Harris deleted the bump-devalue branch September 27, 2024 00:28
@github-actions github-actions bot mentioned this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants