-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix: update_branch with (anchor).data possible undefined on ios devices #15851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
I don't think this is not the right fix, If you do want to work on this we also need a test for it tho. |
Hi @paoloricciuti, |
I'll try to take a look later, no tests are failing because generally the data it's there but I have the feeling that this will break in case there's malformed html...the app might render but the whole hydration mechanism will fail and it will be unresponsive. |
Hi @paoloricciuti , just to share a possible lead — if it helps:
This is not part of the SvelteKit app itself — it’s automatically added by Cloudflare when the Mirage optimization is enabled in the dashboard under Speed > Optimization > Mirage. So if anyone else is seeing unexpected Let me know if this helps clarify things! |
We'd need a test before we could merge this, otherwise it's very likely we'll regress. Can you reproduce the issue? |
Thank you for considering my post 🙏🏻 ...I understand that making such a change could solve one problem but potentially introduce others. To reproduce the issue, I believe you can follow what's already described in the other report: #15819. On my end, I was able to work around it by disabling the option in Cloudflare that was causing it — as shown in the attached screenshot: Under Speed > Optimization > Image Optimization > Mirage > (off) |
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint