Skip to content

feat: allow generics on snippets #15915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 14, 2025
Merged

feat: allow generics on snippets #15915

merged 6 commits into from
May 14, 2025

Conversation

paoloricciuti
Copy link
Member

Closes #15883

This adds support for the parser for the generic syntax on snippets...this can be useful for stuff like

{#snippet list<TItem>(list: TItem[], show: (item: TItem)=>boolean)}
    {#each list as item}
        {#if show(item)}
             {item}
        {/if}
    {/each}
{/snippet}

to be actually functional needs a respective pr in language-tools

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented May 14, 2025

🦋 Changeset detected

Latest commit: 48d78ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15915

@Rich-Harris
Copy link
Member

I think we can reuse some existing bracket matching logic (which is already slightly duplicative) — will push a change

@paoloricciuti
Copy link
Member Author

Uh great idea, thanks

@Rich-Harris Rich-Harris merged commit 66a2155 into main May 14, 2025
13 checks passed
@Rich-Harris Rich-Harris deleted the generic-snippets branch May 14, 2025 19:59
@github-actions github-actions bot mentioned this pull request May 14, 2025
@WarningImHack3r
Copy link

Oh, that was fast and unexpected, thanks Paolo & Rich!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support TypeScript generics on snippets
3 participants