Fix warnings #170
Open
Fix warnings #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petitlapin
commented
Aug 24, 2025
| * "--expert 10". Calling contains("expert") will return true. | ||
| * @see optionArgument() | ||
| */ | ||
| bool contains(const QLatin1String & key) const; |
There was a problem hiding this comment.
Here, either we add a contains with a QLatin1String or we change everywhere to use a QStringLiteral instead of a QLatin1String. From what I understand, as there are overrides for QLatin1String in QListString.contains, it should be faster to have an override instead of using QStringLiteral
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several fixes here:
I've created one commit per check, feel free to merge them if you feel it more appropriate