Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hstr): Prevent memory leak for global stores #10047

Merged
merged 8 commits into from
Feb 19, 2025
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 18, 2025

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Feb 18, 2025
@kdy1 kdy1 self-assigned this Feb 18, 2025
Copy link

changeset-bot bot commented Feb 18, 2025

🦋 Changeset detected

Latest commit: e247ebf

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 marked this pull request as ready for review February 19, 2025 03:02
@kdy1 kdy1 requested a review from a team as a code owner February 19, 2025 03:02
kodiakhq[bot]
kodiakhq bot previously approved these changes Feb 19, 2025
@kdy1 kdy1 merged commit 4718bc0 into swc-project:main Feb 19, 2025
18 checks passed
@kdy1 kdy1 deleted the hstr-leak branch February 19, 2025 03:02
kdy1 added a commit to vercel/next.js that referenced this pull request Feb 19, 2025
### What?

Apply swc-project/swc#10047

### Why?

To reduce memory usage.
@kdy1 kdy1 modified the milestones: Planned, v1.10.18 Feb 19, 2025
Copy link

codspeed-hq bot commented Feb 19, 2025

CodSpeed Performance Report

Merging #10047 will degrade performances by 12.24%

Comparing kdy1:hstr-leak (e247ebf) with main (c28d494)

Summary

⚡ 1 improvements
❌ 45 regressions
✅ 150 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/echarts 2.4 s 2.5 s -3.08%
es/full/minify/libraries/lodash 180.9 ms 186.7 ms -3.14%
es/full/minify/libraries/react 30.1 ms 31.3 ms -3.79%
es/oxc/benches/assets/UserSettings.tsx/sourceMap=true/reactDev=true 1.5 ms 1.6 ms -3.63%
es/oxc/benches/assets/parser.ts/sourceMap=false/reactDev=false 72.3 ms 74.8 ms -3.26%
es/oxc/benches/assets/parser.ts/sourceMap=false/reactDev=true 72.4 ms 74.8 ms -3.21%
es/oxc/benches/assets/renderer.ts/sourceMap=false/reactDev=true 12.1 ms 12.5 ms -3.1%
es/oxc/benches/assets/table.tsx/sourceMap=false/reactDev=false 6.6 ms 6.8 ms -4%
es/oxc/benches/assets/table.tsx/sourceMap=false/reactDev=true 7.5 ms 7.8 ms -3.65%
es/full/all/es2020 169.6 ms 175 ms -3.09%
css/visitor/compare/clone 6 ms 6.3 ms -5.2%
css/visitor/compare/fold_span 7 ms 7.3 ms -4.09%
css/visitor/compare/fold_span_panic 7 ms 7.3 ms -3.72%
css/visitor/compare/visit_mut_span 6.4 ms 6.7 ms -4.63%
css/visitor/compare/visit_mut_span_panic 6.4 ms 6.7 ms -4.79%
css/lexer/bootstrap_5_1_3 9.1 ms 10.4 ms -12.1%
css/lexer/foundation_6_7_4 7.3 ms 8.4 ms -12.24%
css/lexer/tailwind_3_1_1 1.4 ms 1.6 ms -12.17%
css/parser/bootstrap_5_1_3 50.2 ms 52 ms -3.45%
css/parser/foundation_6_7_4 39.6 ms 40.9 ms -3.13%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

hstr: Global atom store should not leak memory
1 participant