[cherry-pick][lldb] Fix stepping through conformance methods #10505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already check this boolean in the `if` statement two lines above.
A future patch will need to create a new constructor for this class, and extracting code out of its sole existing constructor will make this easier. This commit creates a helper function for the code computing the target frame to step out to.
A subsequent commit will create a new constructor for ThreadPlanStepOut, which needs to reuse much of the same logic of the existing constructor. This commit places all of that reusable logic into a separate function.
…6163) The function QueueThreadPlanForStepOutNoShouldStop has the semantics of "go this parent frame"; ThreadPlanStepOut needs to respect that, not skipping over any frames it finds uninteresting. This commit creates a constructor that respects such instruction.
|
@swift-ci test |
felipepiovezan
force-pushed
the
felipe/fix_conformance_stepping
branch
from
fcab55a to
fddb994
Compare
|
Forgot to disable the test on linux/windows. |
|
@swift-ci test |
|
Han, the new test is failing as if the fix weren't there.. |
|
@swift-ci test macos platform |
Have we always done CI with debug symbols for the swift std lib? |
|
Yup, confirmed, the presence of debug symbols in the standard library is causing this test to behave differently because we treat |
|
@swift-ci test |
felipepiovezan
force-pushed
the
felipe/fix_conformance_stepping
branch
from
fddb994 to
1bd67e3
Compare
|
@swift-ci test |
adrian-prantl
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks the upstream LLVM commits fixing stepping through conformance methods.