Skip to content

[BoundsSafety] Accept new CompatibleVoidPtrToNonVoidPtr assign kind. #10592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ahmedbougacha
Copy link

This was introduced in 15321d2.

rdar://150382427

Copy link

@hnrklssn hnrklssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think CompatibleVoidPtrToNonVoidPtr should technically be under the "Not errors" heading, but the behaviour is the same regardless, and CompatiblePointerDiscardsQualifiers already breaks this rule so I won't block on it.

This was introduced in 15321d2.

While there, move CompatiblePointerDiscardsQualifiers with it
to the non-error part of the switch.

rdar://150382427
@ahmedbougacha ahmedbougacha force-pushed the eng/PR-150382427-boundssafety-new-assign-convert-ty-voidptr branch from 0c81266 to 480abbf Compare May 1, 2025 00:14
@ahmedbougacha
Copy link
Author

Sure, I moved both, ty

@ahmedbougacha ahmedbougacha merged commit 005b675 into swiftlang:next May 1, 2025
@ahmedbougacha ahmedbougacha deleted the eng/PR-150382427-boundssafety-new-assign-convert-ty-voidptr branch May 1, 2025 00:14
@delcypher
Copy link

@ahmedbougacha Thanks for fixing this

@delcypher delcypher added the clang:bounds-safety Issue relating to the experimental -fbounds-safety feature in Clang label May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:bounds-safety Issue relating to the experimental -fbounds-safety feature in Clang
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants