Remove the default output buffer limit #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkera
reviewed
May 15, 2025
| @@ -240,10 +240,9 @@ extension OutputProtocol where Self == FileDescriptorOutput { | |||
| @available(SubprocessSpan, *) | |||
| #endif | |||
| extension OutputProtocol where Self == StringOutput<UTF8> { | |||
| /// Create a `Subprocess` output that collects output as | |||
| /// UTF8 String with 128kb limit. | |||
| /// Create a `Subprocess` output that collects output as UTF8 String | |||
There was a problem hiding this comment.
I think the documentation comment here should say that the buffer is unlimited, so the amount of memory required is proportional to the size of the output.
…limited buffer size
|
Updated header doc to indicate that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the output buffer limit by default when setting
.stringor.bytesasoutputorerror.Resolves #44