Introduce custom initializers to initialize String, Data, and Array from AsyncBufferSequence.Buffer #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCharlesHu
force-pushed
the
charles/buffer-improvements
branch
from
36e0e21 to
f261182
Compare
iCharlesHu
changed the title
…rom AsyncBufferSequence.Buffer
iCharlesHu
force-pushed
the
charles/buffer-improvements
branch
from
f261182 to
75b804c
Compare
parkera
reviewed
May 19, 2025
| @@ -267,7 +267,7 @@ public func run<Result, Error: OutputProtocol>( | |||
| environment: Environment = .inherit, | |||
| workingDirectory: FilePath? = nil, | |||
| platformOptions: PlatformOptions = PlatformOptions(), | |||
| error: Error, | |||
| error: Error = .discarded, | |||
glessard
reviewed
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes working with
Buffereasier by introducing convenience initializers onString,Data, andArrayto allow easy creation fromAsyncBufferSequence.Buffer.