Skip to content

[6.2] Add trailing comma support in cases missing from Swift 6.1 #3081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: release/6.2
Choose a base branch
from

Conversation

calda
Copy link

@calda calda commented May 20, 2025

Corresponding compiler PR: swiftlang/swift#81653


Explanation:

This PR fixes bugs in Swift 6.1 where trailing commas are unexpectedly not allowed.

Scope:

This PR fixes a parsing bugs related to trailing commas in a small handful of places:

  • tuple types
  • closure types
  • generic types
  • protocol declaration primary associated type lists

Issues:

Original PR:

#3080

Risk:

Low: Targeted parsing change in a few places missed in the original implementation from Swift 6.1

Testing:

New test cases, Swift CI

Reviewers:

@rintaro

@rintaro
Copy link
Member

rintaro commented May 20, 2025

swiftlang/swift#81653
@swift-ci Please test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants