Use our posix_spawn() wrapper in the Foundation CIO rather than Process.
#1114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added
enhancement
grynspan
force-pushed
the
jgrynspan/use-spawn-code-for-zipping
branch
2 times, most recently
from
32f24a4 to
653a2de
Compare
grynspan
added
the
cross-import-overlays
grynspan
force-pushed
the
jgrynspan/use-spawn-code-for-zipping
branch
2 times, most recently
from
5f86571 to
bedb19f
Compare
|
@swift-ci test |
grynspan
force-pushed
the
jgrynspan/use-spawn-code-for-zipping
branch
from
bedb19f to
279f18f
Compare
|
@swift-ci test |
We already have custom `async`-friendly code for spawning child processes, so let's use it instead of relying on `Foundation.Process` when we need to call the platform's `zip` or `tar` tool. Currently we do this in the Foundation cross-import overlay (hence why we were using `Foundation.Process` at all).
grynspan
changed the title
posix_spawn() in the Foundation CIO rather than Process.posix_spawn() wrapper in the Foundation CIO rather than Process.
grynspan
force-pushed
the
jgrynspan/use-spawn-code-for-zipping
branch
from
279f18f to
1bdfdf5
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have custom
async-friendly code for spawning child processes, so let's use it instead of relying onFoundation.Processwhen we need to call the platform'sziportartool. Currently we do this in the Foundation cross-import overlay (hence why we were usingFoundation.Processat all).Checklist: