Work around a compiler regression affecting exit test value capturing. #1171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR works around a compiler regression as of Swift acbdfef4f4d71b1 that causes our helper macro `#__capturedValue()` to be incorrectly expanded (wrong overload is selected.) The workaround is to disable our use of this macro, which does not affect correct functioning of our code but which does degrade the quality of our diagnostics. Works around rdar://154221449.
grynspan
requested review from
stmontgomery,
briancroom and
suzannaratcliff
as code owners
grynspan
added
workaround
|
@swift-ci test |
stmontgomery
approved these changes
Jun 24, 2025
|
Appears to have been caused by swiftlang/swift#82326. |
|
@swift-ci test |
stmontgomery
approved these changes
Jun 24, 2025
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works around a compiler regression (apparently caused by the change in swiftlang/swift#82326) as of Swift acbdfef4f4d71b1 that causes our helper macro
#__capturedValue()to be incorrectly expanded (wrong overload is selected.) The workaround is to pass captured values as individual arguments instead of as a tuple. (The workaround is temporary because the use of individual arguments makes the trailingcommentargument potentially ambiguous. We'll go back to using a tuple when the compiler bug is fixed.)Works around rdar://154221449.
Checklist: