Ensure that when .serialized is applied to a parameterized @Test func, its test cases are serialized #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, its test cases are serialized Fixes rdar://154529146
stmontgomery
requested review from
briancroom and
suzannaratcliff
as code owners
stmontgomery
added
traits
|
@swift-ci please test |
suzannaratcliff
approved these changes
Jun 30, 2025
grynspan
reviewed
Jun 30, 2025
grynspan
approved these changes
Jun 30, 2025
stmontgomery
added a commit
that referenced
this pull request
Jun 30, 2025
…func, its test cases are serialized (#1190) - **Explanation**: This fixes a regression when `.serialized` is applied directly to a parameterized `@Test` function, not to a containing suite, its test cases are no longer serialized. - **Scope**: Affects the `.serialized` trait when applied to `@Test` functions, specifically, not to suite types. - **Issues**: rdar://154529146 - **Original PRs**: #1188 - **Risk**: <!-- The (specific) risk to the release for taking the changes. --> - **Testing**: New regression test added - **Reviewers**: @suzannaratcliff, @briancroom, @grynspan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in the changes for #901. When
.serializedis applied directly to a parameterized@Testfunction, not to a containing suite, its test cases are no longer serialized. This PR resolves and restores the original behavior by ensuring there is a non-nilscope provider returned for the test function.Checklist:
Fixes rdar://154529146