Require UTType for image attachments.
#1192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR simplifies our image attachment code so that it always requires `UTType` instead of providing implementations for older Apple platforms. > [!NOTE] > Image attachments are an experimental feature.
grynspan
added
public-api
|
@swift-ci test |
|
@swift-ci test |
stmontgomery
reviewed
Jul 2, 2025
stmontgomery
reviewed
Jul 2, 2025
Sources/Overlays/_Testing_CoreGraphics/Attachments/Attachment+AttachableAsCGImage.swift
Show resolved
Hide resolved
stmontgomery
reviewed
Jul 2, 2025
Sources/Overlays/_Testing_CoreGraphics/Attachments/_AttachableImageWrapper.swift
Show resolved
Hide resolved
|
@swift-ci test |
stmontgomery
approved these changes
Jul 2, 2025
|
@swift-ci test |
grynspan
added
the
cross-import-overlays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies our image attachment code so that it always requires
UTTypeinstead of providing implementations for older Apple platforms. For more information about theUTTypeAPI, watch this video. There is a kitty.Image attachments depend on
CGImageand are Apple-specific at this time. Non-Apple image attachment support is a future direction.Note
Image attachments are an experimental feature.
Checklist: