Fixed no copying IsIsolated flag when cloning subscript params #81022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickolas-pohilets
requested review from
ktoso,
hborla,
slavapestov and
xedin
as code owners
hborla
approved these changes
May 2, 2025
|
@swift-ci please smoke test |
I don't see any reason why we wouldn't copy these too. |
nickolas-pohilets
force-pushed
the
mpokhylets/fix-80992
branch
from
65261ff to
22280de
Compare
Will do after merging this one. |
slavapestov
approved these changes
May 13, 2025
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80992
Should
IsVariadicandIsAddressablebe copied as well? I suspectparam->setOptions(subscriptParam->getOptions());would be better than copying flags one by one.