SIL: introduce the vector_base_addr instruction and use it in InlineArray
#81441
+566
−103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
requested review from
a team,
xymus,
jckarter,
rjmccall,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci test |
Azoy
approved these changes
May 12, 2025
* `Type.isBuiltinFixedArray` * `Type.builtinFixedArrayElementType`
The element type must be lowered. Otherwise it would crash for e.g. function types as element types.
It derives the address of the first element of a vector, i.e. a `Builtin.FixedArray`, from the address of the vector itself. Addresses of other vector elements can then be derived with `index_addr`.
…essOfBorrowBuiltins`
Add a `vectorBase` field kind which corresponds to `vector_base_addr`. Also, improve `mayOverlap`: it didn't catch the case that the first element of a vector cannot overlap with another element.
This enables alias analysis and optimizations, like, redundant load elimination, to benefit from it.
Don't unsafe-cast from the InlineArray struct itself, but from `_storage` which is the actual array buffer. This also requires making `_storage` a var.
Reimplement the simplification in swift and add a new transformation: ``` %1 = unchecked_addr_cast %0 : $*Builtin.FixedArray<N, Element> to $*Element ``` -> ``` %1 = vector_base_addr %0 : $*Builtin.FixedArray<N, Element> ```
eeckstein
force-pushed
the
vector_base_addr
branch
from
a76beff to
d28384d
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
vector_base_addrinstruction derives the address of the first element of a vector, i.e. aBuiltin.FixedArray, from the address of the vector itself.Addresses of other vector elements can then be derived with
index_addr.InlineArrayusedunsafe_addr_castfor this purpose. But this is blocking a number of optimizations.Using
vector_base_addrmakes this vector->element projection explicit and optimizations can handle it correctly.This also requires that the
InlineArray._storageproperty (the actualBuiltin.FixedArray) is correctly projected out of theInlineArray- instead of unsafe castingInlineArrayitself to the element type.