Skip to content

[cxx-interop] Build CxxStdlib overlay for static Linux SDK #81448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[cxx-interop] Build CxxStdlib overlay for static Linux SDK #81448

wants to merge 1 commit into from
+1 −1

Conversation

egorzhdan
Copy link
Contributor

rdar://149846747

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label May 12, 2025
@egorzhdan egorzhdan requested review from MaxDesiatov and al45tair May 12, 2025 15:24
@egorzhdan
Copy link
Contributor Author

@swift-ci please test

@egorzhdan egorzhdan marked this pull request as draft May 12, 2025 18:34
@egorzhdan egorzhdan marked this pull request as ready for review May 13, 2025 11:20
@egorzhdan egorzhdan marked this pull request as draft May 13, 2025 11:21
@egorzhdan
Copy link
Contributor Author

The overlay likely won't be built correctly, since the build script is adding libc++ include paths manually via -isystem, while Swift expects -stdlib=libc++.

swift/stdlib/cmake/modules/AddSwiftStdlib.cmake

Line 124 in c5aa98a

list(APPEND result "-isystem" "${SWIFT_MUSL_PATH}/${CFLAGS_ARCH}/usr/include/c++/v1")

@egorzhdan egorzhdan mentioned this pull request May 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-hui j-hui j-hui approved these changes

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@Xazax-hun Xazax-hun Awaiting requested review from Xazax-hun Xazax-hun is a code owner

@fahadnayyar fahadnayyar Awaiting requested review from fahadnayyar fahadnayyar is a code owner

@susmonteiro susmonteiro Awaiting requested review from susmonteiro susmonteiro is a code owner

@MaxDesiatov MaxDesiatov Awaiting requested review from MaxDesiatov

@al45tair al45tair Awaiting requested review from al45tair

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egorzhdan @j-hui