Skip to content

[6.2] [Parse] Avoid parsing unsafe expression before binary or postfix op #81486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hamishknight
Copy link
Contributor

6.2 cherry-pick of #81429

  • Explanation: Avoids parsing an unsafe expression if followed by a binary or postfix operator.
  • Scope: Affects parsing of unsafe.
  • Issue: Compilation error: expected expression after 'unsafe' #81323, rdar://150751248
  • Risk: Low, avoids parsing unsafe expression in cases that would be invalid, adjusts logic to more closely align with the swift-syntax parser logic.
  • Testing: Added tests to test suite
  • Reviewer: Hamish Knight

@hamishknight hamishknight requested a review from bnbarham May 13, 2025 20:11
@hamishknight hamishknight requested a review from a team as a code owner May 13, 2025 20:11
@hamishknight hamishknight added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 labels May 13, 2025
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight merged commit 442f25d into swiftlang:release/6.2 May 14, 2025
5 checks passed
@hamishknight hamishknight deleted the fix-parse-unsafe-ternary-6.2 branch May 14, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants