[6.2][stdlib] SE-0472: Rename Task and*TaskGroup APIs to match the proposal #81488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
Previously there was still a sneaky hop which caused ordering issues. This introduced a specific test startSynchronously_order which checks that the task enqueues indeed are "immediate" and cleans up how we handle this. This also prepares for the being discussed in SE review direction of this API that it SHOULD be ALLOWED to actually hop and NOT be synchronous at all IF the isolation is specified on the closure and is DIFFERENT than the callers dynamic isolation. This effectively implements "synchronously run right now if dynamically on the exact isolation as requested by the closure; otherwise enqueue the task as usual". resolves rdar://149284186 cc @drexin (cherry picked from commit a24a28c)
Reworking semantics of this API so disabling the flaky test, it'll have different sematntics and then the test will be adjusted (cherry picked from commit a3762d4)
(cherry picked from commit b76abb4)
…posal
`Task.startSynchronously` -> `Task.immediate`
`*TaskGroup.startTaskSynchronously{UnlessCancelled}` -> `*TaskGroup.addImmediateTask{UnlessCancelled}`
(cherry picked from commit 001eab8)
(cherry picked from commit 99d810a)
xedin
force-pushed
the
rename-some-task-apis-6.2
branch
from
cc25b6e to
b2e9620
Compare
|
@swift-ci please test |
ktoso
approved these changes
May 14, 2025
hborla
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #80821 and #81428
Explanation:
Renames:
Task.startSynchronously->Task.immediate*TaskGroup.startTaskSynchronously{UnlessCancelled}->*TaskGroup.addImmediateTask{UnlessCancelled}Task.immediate- Previously there was still a sneaky hop which caused ordering issues. This introduced a specific teststartSynchronously_orderwhich checks that the task enqueues indeed are "immediate" and cleans up how we handle this.Main Branch PRs: [Concurrency][startSynchronously] Improve in order synchronous enqueue of startSynchronously #80821, [stdlib] SE-0472: Rename
Taskand*TaskGroupAPIs to match the pro… #81428Risk: Low (This is mostly a rename of the only APIs (which leaves
Task.startSynchronouslyas deprecated and an additional change to make sure that there are no extra hops when using these APIs).Reviewed By: @ktoso @hborla (rename), @drexin (ordering fix).
Resolves: rdar://149284186
Testing: Updated tests to use new names.