Runtimes: correct CommandLineSupport build on Windows #81490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would fail to build the runtime with the new build with command line support and a shared runtime. The reason for this was that CommandLineSupport did not properly build against the headers and attempted to import a locally defined symbol. Correct the build by indicating that this library is compacted into the runtime.
compnerd
requested review from
etcwilde,
edymtt and
justice-adams-apple
as code owners
|
@swift-ci please smoke test |
etcwilde
approved these changes
May 13, 2025
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would fail to build the runtime with the new build with command line support and a shared runtime. The reason for this was that CommandLineSupport did not properly build against the headers and attempted to import a locally defined symbol. Correct the build by indicating that this library is compacted into the runtime.