Set debug location to Coroutine call expression #81495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If debug info generation is enabled, set debug location to the coroutine call instruction to make sure there are no issues with invalid debug information in LTO. This happens because in LTO, if a call to a function doesn't contain a debug location, we see the warning: inlinable function call in a function with debug info must have a !dbg location ld: warning: Invalid debug info found, debug info will be stripped Which then strips the debug info from the entire .o file linked into the dylib. (cherry picked from commit 17e756b)
|
@swift-ci please test |
adrian-prantl
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry picked from commit 17e756b #81463
Explanation: This change makes sure that a debug location is attached to a coroutine call instruction to make sure there are no issues with invalid debug information in LTO. If LTO detects any invalid debug info, such as an instruction without a debug location, when compiled with debug info, the debug info for that translation unit will be stripped.
Scope: limited to swift.org toolchains
Risk: low, the change is additive and doesn't impact anything else
Testing: automated testing via github.com/swiftlang/swift-integration-tests
Issue: rdar://149574283
Reviewer: @adrian-prantl