[6.2] FunctionSignatureOptimization: don't convert indirect @in to @in_guaranteed if the argument is mutated
#81497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lable Also, make it more tolerant to instructions and builtins, which are not explicitly handled. This avoids crashes when new instructions are added. We got lucky that this didn't happen so far.
…uaranteed` if the argument is mutated This fixes a verifier error because an `@in_guaranteed` argument must not be mutated. swiftlang#81444 rdar://151147971
|
@swift-ci test |
tbkka
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@inargument to an@in_guaranteedargument, even if the argument is mutated. This is wrong because an@in_guaranteedargument must not be mutated.@into@in_guaranteedif the argument is mutated #81480