[6.2][IRGen] Don't set HasLayoutString flag on non-copyable generic types #81531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
drexin
commented
May 15, 2025
drexin
commented
- Explanation: While generic types generally have layout strings (when enabled), non-copyable types don't, so we have to make sure the flag does not get set.
- Scope: Type metadata flags for compact value witnesses
- Issues: rdar://151176697
- Original PRs: [IRGen] Don't set HasLayoutString flag on non-copyable generic types #81530
- Risk: Low. This flag is only used when compact value witnesses are enabled.
- Testing: Added regression tests for structs and enums.
- Reviewers: @aschwaighofer @mikeash
rdar://151176697 While generic types generally have layout strings (when enabled), non-copyable types don't, so we have to make sure the flag does not get set.
|
@swift-ci test |
drexin
changed the title
tbkka
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.