Skip to content

[6.2][Concurrency] Add underscore prefixes for not yet official API. #81532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

al45tair
Copy link
Contributor

Custom main and global executors work hasn't passed Swift Evolution yet, so we need to avoid leaking it as API until it does.

To that end, underscore all the things.

rdar://151147606

Custom main and global executors work hasn't passed Swift Evolution yet,
so we need to avoid leaking it as API until it does.

To that end, underscore all the things.

rdar://151147606
@al45tair al45tair requested a review from a team as a code owner May 15, 2025 17:43
@al45tair al45tair added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 labels May 15, 2025
@al45tair
Copy link
Contributor Author

@swift-ci Please test

@al45tair
Copy link
Contributor Author

Explanation: The custom main and global executors work hasn't yet passed Swift Evolution, so to avoid giving the impression that it's official API already, underscore all the new public things.
Risk: Low. Just adds underscores to new functionality.
Original PR: #81472
Reviewed by: @ktoso
Resolves: rdar://151147606
Tests: There are Concurrency tests covering all of this, and things just won't build if we've missed an underscore somewhere.

Copy link
Member

@hborla hborla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need a different solution; this API surface is still committed to ABI with this change. I also don't believe this is low risk, because adding the underscores changes ABI.

@al45tair
Copy link
Contributor Author

Closing this as we're apparently not doing this.

@al45tair al45tair closed this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants