Cache the last ObjC bridging conformance we looked up #81545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please Apple Silicon benchmark |
|
@swift-ci please Apple Silicon benchmark |
Catfish-Man
commented
May 15, 2025
| } | ||
|
|
||
| static const _ObjectiveCBridgeableWitnessTable * | ||
| findBridgeWitness(const Metadata *T) { |
There was a problem hiding this comment.
This entire function is duplicated between DynamicCast.cpp and Casting.cpp, along with its memoization variables. There's also a separate memoization of String stuff in DynamicCast.cpp. I'm unifying the behavior of these (yes they had behavior differences), but saving actually unifying the implementations for later.
|
1.23x improvement in ObjectiveCBridgeToNSDictionary :) still waiting on my local build to verify the improvement in the new test |
|
@swift-ci please test |
Catfish-Man
changed the title
mikeash
approved these changes
May 16, 2025
tbkka
reviewed
May 16, 2025
|
Looks fine. |
tbkka
approved these changes
May 16, 2025
|
@swift-ci please benchmark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://151475392