Improve LifetimeDependenceDefUseWalker: consult DestructorAnalysis. #81551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks the members of a value type to determine whether its synthesized deinitializer can have side effects. Add support for enum and fixed array. Add support for generic types. The old code was inexplicably failing to apply the aggregate's type substitutions to the members.
Fixes rdar://150828355 (Overlapping access error after the last use of a lifetime-dependent span variable)
|
@slavapestov since this will be a late change to 6.2, could you check that this use of substitution maps makes sense? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix DestructorAnalysis: handle enum, FixedArray, and generic types.
This checks the members of a value type to determine whether its synthesized
deinitializer can have side effects.
Add support for enum and fixed array.
Add support for generic types. The old code was inexplicably failing to apply
the aggregate's type substitutions to the members.
SwiftCompilerSources: bridge DestructorAnalysis.
Add DestructorAnalysis to LifetimeDependenceDefUseWalker.
[NFC] LifetimeDependence: fix internal debug output
Improve LifetimeDependenceDefUseWalker: consult DestructorAnalysis.
Fixes rdar://150828355 (Overlapping access error after the last use
of a lifetime-dependent span variable)