Skip to content

[6.2] [Driver] Avoid using response files for SourceKit #81559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2025

Conversation

hamishknight
Copy link
Contributor

6.2 cherry-pick of #81555

  • Explanation: Avoids creating redundant response files when retrieving the frontend arguments for SourceKit
  • Scope: Affects SourceKit
  • Issue: rdar://98880399
  • Risk: Low, the response files never got used
  • Testing: Added test to test suite
  • Reviewer: Ben Barham

We only care about the frontend arguments here, creating a response
file is unnecessary.

rdar://98880399
@hamishknight hamishknight requested a review from bnbarham May 16, 2025 16:36
@hamishknight hamishknight requested a review from a team as a code owner May 16, 2025 16:36
@hamishknight hamishknight added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 labels May 16, 2025
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight enabled auto-merge May 16, 2025 18:27
@hamishknight hamishknight merged commit 4b2d879 into swiftlang:release/6.2 May 17, 2025
5 checks passed
@hamishknight hamishknight deleted the no-response-6.2 branch May 17, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants