[6.2] AST, Sema: Cherry-pick 4 NonisolatedNonsendingByDefault bug fixes
#81573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rence Introduction of `@concurrent` attribute caused an unintended side-effect in `ClosureEffectsRequest` since the attribute could only be used on `async` types setting `async` too early prevented body analysis for `throws` from running. Resolves: rdar://151421590 (cherry picked from commit cda9866)
…capture lists (cherry picked from commit d90c7cb)
…nding)` is explicit This broke when we split `@execution(...)` into `@concurrent` and `nonisolated(nonsending)` because the latter became its own `TypeRepr`, whereas the condition for whether to attempt migration diagnostics inside `resolveASTFunctionType` is still based on the function type's attributes alone. (cherry picked from commit bee2b67)
The diagnostic can outlive the locally constructed attribute, which was passed by pointer, if there is an active `DiagnosticTransaction`. (cherry picked from commit f4e49d5)
|
@swift-ci please test |
hborla
approved these changes
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InFlightDiagnostic::fixItAddAttributewas not accounting for this.nonisolated(nonsending)is explicit. This broke when we split@execution(...)into@concurrentandnonisolated(nonsending)because the latter became its ownTypeRepr, whereas the condition for whether to attempt migration diagnostics insideresolveASTFunctionTypewas still based on the function type's attributes alone.@concurrenton closures from skippingthrowsinference. Introduction of@concurrentattribute caused an unintended side-effect inClosureEffectsRequestsince the attribute could only be used onasynctypes settingasynctoo early prevented body analysis forthrowsfrom running.NonisolatedNonsendingByDefaultmigration diagnosis. The diagnostic can outlive the locally constructed attribute, which was passed by pointer, if there is an activeDiagnosticTransaction.NonisolatedNonsendingByDefaultmigration. This code is currently the only client ofInFlightDiagnostic::fixItAddAttribute.throwsinference for@concurrentclosures.NonisolatedNonsendingByDefaultmigration diagnosis.NonisolatedNonsendingByDefaultbugs #81538@concurrenton closures from skippingthrowsinfe… #81549NonisolatedNonsendingByDefaultmigration diagnosis #81570swift package migrateagainstswift-build.