Adopt ABORT throughout the compiler
#81604
Open
+894
−761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
xymus,
AnthonyLatsis,
slavapestov,
hborla,
xedin,
eeckstein,
jckarter,
adrian-prantl,
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
DougGregor and
tshortli
as code owners
hamishknight
force-pushed
the
pretty-crash
branch
from
e250539 to
fa3629e
Compare
hamishknight
changed the title
abortWithPrettyStackTraceMessage throughout the compilerABORT throughout the compiler
Improve the formatting by indenting to match the rest of the pretty stack trace.
It's not clear this is a useful utility to expose since it will only print the message once.
Turn it into a wrapping macro that includes the file location, and move into `Assertions.h`.
Make sure we still output the error message when pretty backtracing is disabled.
Ensure the message gets printed to the pretty stack trace, allowing it to be picked up by CrashReporter.
We already setup a PrettyStackTrace to include the generic signature on a crash.
Convert a bunch of places where we're dumping to stderr and calling `abort` over to using `ABORT` such that the message gets printed to the pretty stack trace. This ensures it gets picked up by CrashReporter.
hamishknight
force-pushed
the
pretty-crash
branch
from
fa3629e to
edca7c8
Compare
|
@swift-ci please test |
slavapestov
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn
abortWithPrettyStackTraceMessageinto the wrapping macroABORT, then convert a bunch of places where we're dumping to stderr and callingabort(includingASSERTand friends) over to using this new macro such that the message gets printed to the pretty stack trace. This ensures it gets picked up by CrashReporter.