[6.2] SILGen: insert an end_lifetime in the throw-branch of a Builtin.emplace
#81606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…place` When the called closure throws an error, it needs to clean up the buffer. This means that the buffer is uninitialized at this point. We need an `end_lifetime` so that the move-only checker doesn't insert a wrong `destroy_addr` because it thinks that the buffer is initialized. Fixes a mis-compile. rdar://151461109
|
@swift-ci test |
tbkka
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InlineArray.initfor arrays with certain non-trivial types. The move-only checker inserted a wrong destroy on the throwing path in the initializer. But this is wrong because the initializer has already cleaned up the array buffer when the closure throws. The fix is to insert anend_lifetimeinstruction so that the move-only checker doesn't insert a wrongdestroy_addr.InlineArrayinitializer. This is the only place where the builtin is used with a (potentially) throwing closure.end_lifetimein the throw-branch of aBuiltin.emplace#81567