[cmake] add Synchronization specific cache files #81618
Conversation
justice-adams-apple
requested review from
etcwilde,
compnerd and
edymtt
as code owners
|
@swift-ci please smoke test |
| endif() | ||
|
|
||
| if(NOT DEFINED SwiftSynchronization_TARGET_VARIANT_DEPLOYMENT_TARGET) | ||
| message(WARNING "SwiftSynchronization_TARGET_VARIANT_DEPLOYMENT_TARGET not defined") |
There was a problem hiding this comment.
We may want to make this an error instead of just a warning.
| message(WARNING "SwiftSynchronization_TARGET_VARIANT_DEPLOYMENT_TARGET not defined") | |
| message(SEND_ERROR "SwiftSynchronization_TARGET_VARIANT_DEPLOYMENT_TARGET not defined") |
| @@ -0,0 +1,106 @@ | |||
| # Toolchain configuration when compiling for Darwin Platforms | |||
There was a problem hiding this comment.
We can likely share the toolchain file since it's only setting up the compilers and such that are used while compiling.
I don't think that this is setting anything specific to the Synchronization library. It's just the cache files that are setting project-specific options.
Maybe stick it in Runtimes/Supplemental/cmake/toolchains/Vendors/Apple/Darwin.toolchain.cmake?
@compnerd, do you have any opinions on the file layout for the toolchain files?
There was a problem hiding this comment.
I suppose I am left wondering why are the caches in Runtimes/Supplemental/cmake/toolchains/Vendors/Apple rather than say Runtimes/cmake/caches/ and Runtimes/cmake/toolchains/.
| endif() | ||
|
|
||
| if(NOT DEFINED SwiftSynchronization_TARGET_VARIANT_DEPLOYMENT_TARGET) | ||
| message(WARNING "SwiftSynchronization_TARGET_VARIANT_DEPLOYMENT_TARGET not defined") |
There was a problem hiding this comment.
Maybe make this an error?
| message(WARNING "SwiftSynchronization_TARGET_VARIANT_DEPLOYMENT_TARGET not defined") | |
| message(SEND_ERROR "SwiftSynchronization_TARGET_VARIANT_DEPLOYMENT_TARGET not defined") |
| @@ -0,0 +1,106 @@ | |||
| # Toolchain configuration when compiling for Darwin Platforms | |||
There was a problem hiding this comment.
I suppose I am left wondering why are the caches in Runtimes/Supplemental/cmake/toolchains/Vendors/Apple rather than say Runtimes/cmake/caches/ and Runtimes/cmake/toolchains/.
|
|
||
| if(NOT CMAKE_OSX_SYSROOT) | ||
| if(NOT DEFINED ENV{SDKROOT}) | ||
| message(FATAL_ERROR "The 'SDKROOT' environment variable is not set") |
There was a problem hiding this comment.
| message(FATAL_ERROR "The 'SDKROOT' environment variable is not set") | |
| message(FATAL_ERROR "`CMAKE_OSX_SYSROOT` and the 'SDKROOT' environment variable are not set") |
Add the cache files relevant for building the Synchronization supplemental library