[6.2][Sema/stdlib] SE-0472: implement @_inheritActorContext(always) and adopt it in Task.immediate APIs
#81645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extend `@_inheritActorContext` attribute to support optional `always` modifier. The new modifier will make closure context isolated even if the parameter is not captured by the closure. - Implementation `@_inheritActorContext` attribute validation - it could only be used on parameter that have `@Sendable` or `sending` and `@isolated(any)` or `async` function type (downgraded to a warning until future major Swift mode to avoid source compatibility issues). - Add a new language feature that guards use of `@_inheritActorContext(always)` in swift interface files - Update `getLoweredLocalCaptures` to add an entry for isolation parameter implicitly captured by `@_inheritActorContext(always)` - Update serialization code to store `always` modifier (cherry picked from commit 04d4676) (cherry picked from commit c050e8f) (cherry picked from commit c0aca53) (cherry picked from commit a4f6d71) (cherry picked from commit 6c911f5) (cherry picked from commit 17b8f7e)
…tanceCapture` for parameters SILGen expects actor instance isolation to always come from captures, we need to maintain that with implicit isolation capture performed by `@_inheritActorContext(always)`. (cherry picked from commit 9104744)
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #81496, #81543, #81572
Explanation:
Implements a new mode for
@_inheritActorContextattribute that would force capture of isolation context even when isolated parameter is not captured by the closure and use updated attribute to implementTask.immediateas discussed in the SE-0472.Main Branch PRs: [AST/Sema/SIL] Implement
@_inheritActorContext(always)#81496, [Concurrency] Fix@_inheritActorContext(always)to use `forActorIns… #81543, [stdlib] Adopt@_inheritActorContext(always)onTask.immediate#81572Risk: Low (Similarly to
Task.startSynchronously->Task.immediatethis is a low risk change because there are no adopters for the attribute mode yet andTask.immediateAPIs is going through evolution as well).Reviewed By: @ktoso
Testing: Added new tests to the suite.