Skip to content

🍒[cxx-interop] Relax a SILVerifier assertion for immortal reference types #81674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

egorzhdan
Copy link
Contributor

@egorzhdan egorzhdan commented May 21, 2025

Immortal C++ foreign reference types get TrivialTypeLowering instead of ReferenceTypeLowering, since they do not have retain/release lifetime operations. This was tripping up an assertion in SILVerifier.

rdar://147251759 / resolves #80065
(cherry picked from commit 2e3df1c)
@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label May 21, 2025
@egorzhdan
Copy link
Contributor Author

@swift-ci please test

@egorzhdan egorzhdan marked this pull request as ready for review May 21, 2025 12:11
@egorzhdan egorzhdan requested a review from a team as a code owner May 21, 2025 12:11
@egorzhdan egorzhdan merged commit 36511a2 into release/6.2 May 21, 2025
5 checks passed
@egorzhdan egorzhdan deleted the egorzhdan/6.2-silverifier-trivial-frt branch May 21, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants