BridgeJS: Fix nested type resolution for MemberTypeSyntax (e.g., Networking.API.Method) #433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently for functions that would be using nested types like:
We'd get following error:
Issue is that currently
lookupType(for
only handlesIdentifierTypeSyntax
, henceMemberTypeSyntax
likeNetworking.API.Method
would not be resolved to a valid declaration.Fix
Centralized type resolution in
TypeDeclResolver
with a newresolve(_: TypeSyntax)
API and used it inExportSwift
to map nested enums/classes/actors toBridgeType
. This should help with nested types resolution, while exported ABI remains unchanged for already-supported types.New tests were added to
prelude.mjs
to confirm the fix.