-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Summary row scroll #1479
base: master
Are you sure you want to change the base?
Summary row scroll #1479
Conversation
Is there any chance this could be accepted and merged? Making the sumrow fixed would be a very useful feature.. |
Can this be merged? It would be really helpful if I can make the summary row fixed on the top |
@SirWojtek what about this merge? SummaryRow fixed is something really needed... |
This pull request introduces 7 alerts and fixes 1 when merging 34ab71d into 8a352ed - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 1 alert when merging 9c1f3bd into 8a352ed - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging f3fe7c7 into 8a352ed - view on LGTM.com new alerts:
|
Hey @marjan-georgiev, I've rebased the fix and re-checked if it's still relevant. Can I ask you to review it? It has been a long time since I worked with ngx-datatable, I could miss something. |
This pull request fixes 1 alert when merging 53706cd into 8a352ed - view on LGTM.com fixed alerts:
|
When will this feature be available? 😄 |
Hey @ratiuandreea, still waiting for code review. @marjan-georgiev would be nice if you could find some time to take a look at this PR :) |
Is there a plan to merge this at all? Having the same issue with summary row not being shown unless you scroll to the bottom.. |
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
#1462
What is the new behavior?
#1462
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: