Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flex column resize #1495

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Toktik
Copy link
Contributor

@Toktik Toktik commented Jul 24, 2018

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
When the column mode is flex, the resize on columns does not work

What is the new behavior?
Column resize fixed in case of flex column mode

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@EduardsE
Copy link

Tried forking repo, committing these changes, using the repo as dependency in my project, but it still wouldn't work.

dr-itz added a commit to siemens/ngx-datatable that referenced this pull request Sep 21, 2021
dr-itz added a commit to siemens/ngx-datatable that referenced this pull request Sep 21, 2021
fh1ch pushed a commit to siemens/ngx-datatable that referenced this pull request Sep 21, 2021
* fix: fix column resizing basic cases

Still broken: flex, column pinning

* fix: fix flex column resizing

See swimlane#1495

* fix: make column resize with pinned columns work a bit better
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants