Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #527 column pinning have some styling bugs #1524

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tonny008
Copy link

What kind of change does this PR introduce? (check one with "x")

  • [x ] Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
column head and column body not aligned
the innerWidth is set to width getBoundingRect
What is the new behavior?
column head and column body aligned
innerWidth is set clientWidth

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • [x ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@tonny008
Copy link
Author

related to pr #810

@vmohir
Copy link

vmohir commented Aug 28, 2018

I have installed v13.1.0 and I still have this problem. Which version will have the fix?

@Atry
Copy link

Atry commented Jan 28, 2019

I applied this patch on v14.0.0 and it works.

@fyidev
Copy link

fyidev commented May 20, 2019

I'm on v14 and am still having the issue.

@SanaeHanaoui
Copy link

also still in the version 16.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants