Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't parse HTML Content in body cell #1158 #1536

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BrummbQ
Copy link
Contributor

@BrummbQ BrummbQ commented Aug 31, 2018

This straight up addresses issue #1158 For discussion and reasoning see there

@jeremyben
Copy link

Like I said in the issue :
When you use the [innerHtml] directive, as ngx-datatable does, Angular already sanitizes the html content beforehand, so no vulnerability to XSS attacks.

See:
https://angular.io/guide/security
https://angular.io/api/platform-browser/DomSanitizer

I think this will limit a ngx-datatable feature (direct output of html in a cell) without adding security as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants