-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser resize distorts ngx-datatable when used with material tabs #1561
base: master
Are you sure you want to change the base?
Browser resize distorts ngx-datatable when used with material tabs #1561
Conversation
When can we expect this PR to get in? This repo has lots of issues opened which this PR addresses |
Is it possbile to merge this resolution? We have a performance problem that we can't resolve unitl this PR. Thanks |
When can we expect this to be merged? |
I think I'm hitting the same issue and am also waiting on this to be merged. |
Anybody has an idea when this will be merged? |
Correct me if i'm wrong, but this is not related to material tabs, but instead related to the table having problems with settings the width of the columns when the table is not visible, right? I am also struggling with this atm. |
Any idea when this fix will get merged? And if not soon, any workarounds? |
Hi Guys, can anyone merge this pull request? |
Hi, |
Any update to this @marjan-georgiev? |
@marjan-georgiev Would be great to see this merged |
Can this please be merged! |
Why can't this pr be merged and released? This is an annoying issue. |
That's something id like to know too. I don't exactly think this is still
actively maintained tho. I've had to use a `forceResize` method
…On Wed, 12 Jun 2019, 21:27 Kyle, ***@***.***> wrote:
@marjan-georgiev <https://github.com/marjan-georgiev>
Why can't this pr be merged and released? This is an annoying issue.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1561?email_source=notifications&email_token=AHDNOO3HMQQMDI4MG4XX4ETP2FL25A5CNFSM4FWV2DKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXRWPLQ#issuecomment-501442478>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHDNOOZETZ56CDD4YKF6OILP2FL25ANCNFSM4FWV2DKA>
.
|
Hi, this has been a very long-time persisting issue. Please update on the fix as soon as possible. Thanks |
@sheiidan what is the status here? We really need this to be resolved. |
Bump. Please consider merging this. |
Any updates on merging of this PR |
Please merge this! |
@marjan-georgiev Is there any chance of this or another change to fix this issue being merged in? |
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
This PR fixes the datatable bug which usually occurs when you put datatable inside Material Tabs and then you resize the window. In such case, the column widths will get distorts (in Force mode) since the visibilityObserver directive has a bug - it raises the visibility change event too early and as a result the width is too small
What is the new behavior?
visibilityObserver directive is now use visibilityService to provide the visibilityChange event. visibilityService is using Intersection Observer API in case the browser supports it. Otherwise it fallback
to the current implementation. In case of old browser I recommend to use a pollyfill for Intersection Observer API instead of falling back to the current buggy implemtation
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Fixes #1325
Fixes #1165
Fixes #1526
Fixes #923
I also added a Demo section for Material Tabs