Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser resize distorts ngx-datatable when used with material tabs #1561

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sheiidan
Copy link

@sheiidan sheiidan commented Sep 22, 2018

What kind of change does this PR introduce? (check one with "x")

  • [x ] Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
This PR fixes the datatable bug which usually occurs when you put datatable inside Material Tabs and then you resize the window. In such case, the column widths will get distorts (in Force mode) since the visibilityObserver directive has a bug - it raises the visibility change event too early and as a result the width is too small

What is the new behavior?
visibilityObserver directive is now use visibilityService to provide the visibilityChange event. visibilityService is using Intersection Observer API in case the browser supports it. Otherwise it fallback
to the current implementation. In case of old browser I recommend to use a pollyfill for Intersection Observer API instead of falling back to the current buggy implemtation

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • [x ] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
Fixes #1325
Fixes #1165
Fixes #1526
Fixes #923

I also added a Demo section for Material Tabs

@sheiidan
Copy link
Author

When can we expect this PR to get in? This repo has lots of issues opened which this PR addresses

@astalegale
Copy link

Is it possbile to merge this resolution? We have a performance problem that we can't resolve unitl this PR.

Thanks

@Broeils
Copy link

Broeils commented Nov 15, 2018

When can we expect this to be merged?

@adamkasztenny
Copy link

I think I'm hitting the same issue and am also waiting on this to be merged.

@chsami
Copy link

chsami commented Jan 9, 2019

Anybody has an idea when this will be merged?

@Moulde
Copy link

Moulde commented Feb 12, 2019

Correct me if i'm wrong, but this is not related to material tabs, but instead related to the table having problems with settings the width of the columns when the table is not visible, right?

I am also struggling with this atm.
I wonder if this pull fixed the issues i'm seeing too.

@oneEyedSunday
Copy link

Any idea when this fix will get merged? And if not soon, any workarounds?

@ngobaut
Copy link

ngobaut commented Mar 7, 2019

Hi Guys, can anyone merge this pull request?

@kaushalndesai23
Copy link

Hi,
Can anyone please merge this?

@DanielMcAssey
Copy link

Any update to this @marjan-georgiev?

@abney317
Copy link

@marjan-georgiev Would be great to see this merged

@jackkettle
Copy link

Can this please be merged!

@kthomas182
Copy link

@marjan-georgiev

Why can't this pr be merged and released? This is an annoying issue.

@oneEyedSunday
Copy link

oneEyedSunday commented Jun 12, 2019 via email

@donnalmh
Copy link

Hi, this has been a very long-time persisting issue. Please update on the fix as soon as possible. Thanks

@SerdarNur
Copy link

@sheiidan what is the status here? We really need this to be resolved.

@AllSeeingEye
Copy link

Bump. Please consider merging this.

@Chinmoyee30
Copy link

Any updates on merging of this PR

@elliotwesoff
Copy link

Please merge this!

@DTKraft
Copy link

DTKraft commented Oct 28, 2021

@marjan-georgiev Is there any chance of this or another change to fix this issue being merged in?
Thanks

@Arti3DPlayer
Copy link

#1325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment