Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue that the loading indicator won't show when there's no row d… #1652

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −0
Open

Fix issue that the loading indicator won't show when there's no row d… #1652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix issue that the loading indicator won't show when there's no row d… 
…ata and scrollbarH is on.
  • Loading branch information
Raymond authored and Raymond committed Feb 17, 2019
commit 12f61bac0d8f63e83a8900341cea6bdfba62d30f
1 change: 1 addition & 0 deletions demo/basic/basic-auto.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import { Component } from '@angular/core';
[headerHeight]="50"
[footerHeight]="50"
[rowHeight]="'auto'"
[scrollbarH]="true"
[reorderable]="reorderable">
</ngx-datatable>
</div>
Expand Down
5 changes: 5 additions & 0 deletions src/components/body/body.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,11 @@ import { MouseEvent } from '../../events';
*ngIf="!rows?.length && !loadingIndicator"
[innerHTML]="emptyMessage">
</div>
<div
class="empty-row"
*ngIf="!rows?.length && loadingIndicator"
[innerHTML]="">
</div>
</datatable-selection>
`,
changeDetection: ChangeDetectionStrategy.OnPush,
Expand Down