Pass extra columns as input to table + columns optional initial order #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duredhel13
requested review from
marjan-georgiev and
Hypercubed
and removed request for
marjan-georgiev and
Hypercubed
| }) | ||
| export class ReusabilityComponent { | ||
| rows = []; | ||
|
|
There was a problem hiding this comment.
Is it really reusable when you are hard-coding the column values at component level.
The reason i said this because i tried using the same thing but the passing the data via @input property and it throws error
There was a problem hiding this comment.
The columns passed via @input need to be of type QueryList<DataTableColumnDirective>, I assume it will fail any other way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
The dynamic addition of columns doesn't work out of the box. This is useful for reusability of a certain table, with the ability to add more columns.
What is the new behavior?
Users can pass extra columns to the table via
@Input()in the form of aQueryList<DataTableColumnDirective>. Users can also define an initial order for columns to override the initial position where they will be rendered.Refer to
Docs/Basic/Reusabilityfor examples on how to use this new functionality.Please note that Angular does not currently support content projection for multiple levels of components. So it is necessary to pass the columns via
@Input(). This issue is tracked here:https://github.com/angular/angular/issues/8563.Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: