Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes calculation of scrollbar width when window scrollbar appears #1906

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

mayuska
Copy link

@mayuska mayuska commented Jul 7, 2020

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

  • If the window vertical scrollbar appears after table is created, horizontal scrollbar appears because datatable-scroller keeps same width as it was before scrollbar.

What is the new behavior?
Horizontal scrollbar should not be set because window vertical scrollbar appeared.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@slavede
Copy link

slavede commented Jul 7, 2020

This one's nice. It would be great to get it in as soon as possible.

@slavede
Copy link

slavede commented Dec 6, 2021

What's up with this PR? Will it ever get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants